Address review feedback on CI lint workflow

- Fix ((errors++)) causing early exit under set -e
- Fix command injection in workflow by using env variable
- Add strategy/ directory to lint paths and AGENT_DIRS
This commit is contained in:
jiangnan
2026-03-06 06:03:35 +08:00
parent 976c08e4c3
commit 2ded8e99a8
2 changed files with 11 additions and 7 deletions

View File

@@ -12,6 +12,7 @@ on:
- 'support/**'
- 'spatial-computing/**'
- 'specialized/**'
- 'strategy/**'
jobs:
lint:
@@ -28,7 +29,7 @@ jobs:
FILES=$(git diff --name-only --diff-filter=ACMR origin/${{ github.base_ref }}...HEAD -- \
'design/*.md' 'engineering/*.md' 'marketing/*.md' 'product/*.md' \
'project-management/*.md' 'testing/*.md' 'support/*.md' \
'spatial-computing/*.md' 'specialized/*.md')
'spatial-computing/*.md' 'specialized/*.md' 'strategy/*.md')
echo "files=$FILES" >> "$GITHUB_OUTPUT"
if [ -z "$FILES" ]; then
echo "No agent files changed."
@@ -39,6 +40,8 @@ jobs:
- name: Run agent linter
if: steps.changed.outputs.files != ''
env:
CHANGED_FILES: ${{ steps.changed.outputs.files }}
run: |
chmod +x scripts/lint-agents.sh
./scripts/lint-agents.sh ${{ steps.changed.outputs.files }}
./scripts/lint-agents.sh $CHANGED_FILES